feat: use CurveStableSwapMetaNG contract #893
Conversation
|
Hi @rndquu I started the review, and did a quick scan first to get understanding of the changes. Since the pull request is big, it will take me some time to process. I will check the new curve implementation docs and go through the changes again tomorrow morning with a fresh brain and provide my feedback. |
There was a problem hiding this comment.
All right! I needed a strong coffee. I am approving from my side as well.
My main takeaways noted during the review:
-
TWAPOracleDollar3poolFacetandIMetaPoolremoved in favor ofICurveStableSwapMetaNG -
MockMetaPoolis nowMockCurveStableSwapMetaNG. -
twapOracleDollar3PoolFacetImplementationis out, meaning one facet less to deploy. Curve metapool is now stored and fully managed inmanagerFacet. -
Metapool layout is as before, Dollar token first (index 0), 3CRV token has index 1.
-
TWAP price for Dollar is now available as
ICurveStableSwapMetaNG(store.stableSwapMetaPoolAddress).price_oracle(0);
| // get Dollar price from Curve Metapool (18 decimals) | ||
| uint256 dollarPriceUsdD18 = LibTWAPOracle.getTwapPrice(); | ||
| uint256 dollarPriceUsdD18 = ICurveStableSwapMetaNG( |
There was a problem hiding this comment.
Pairing Dollar with the tripool will still cause this issue, even if the pool used is a StableSwapMetaNG and not the old curve pools.
Recommendation:
The best solution to achieve an actual peg to $1 would be to use Chainlink price feeds instead. or to pair Dollar with a different asset that is actually pegged to $1 rather than 3CRV, given that currently the pool price will tend to follow 3CRV's price, which currently trades at $1.03.
This PR removes our current TWAP implementation and refactors the code to use the latest curve's metapool implementation with TWAP built-in.
Resolves: